I said that what matters is the price at which she sells or spends it. The reasoning holds good either way.lYou are way overthinking this. Its not an investment, its spending money for her holliers, there will be no price at which she sells. She will spend a little more or a little less eating out in NY.
The total amount of USD which she buys for this purpose may be small, which means the advantage or disadvantage of exchange rate movements will be very small indeed. But I'm addressing the general question of how you time currency purchases, given that you can't forecast currency movements. This would matter more to people b=uying a larger amount of USD.
No-one knows whether the exchange rate will improve or disimprove in the coming months and for that reason we cannot say that now is "a good time".If she buys now she will have the satisfaction of knowing she bought at a good time, sauce for the steak. Will there be a better time in the coming months. No one knows.